alamb commented on PR #8414: URL: https://github.com/apache/arrow-datafusion/pull/8414#issuecomment-1843736049
I also did some ad hoc performance testing and this change did not change the performance for count distinct queries for me: ``` andrewlamb@Andrews-MacBook-Pro:~/Downloads$ /Users/andrewlamb/Software/arrow-datafusion/datafusion-cli/target/release/datafusion-cli -c 'select count(distinct trace_id), count(distinct "span.kind") from traces group by "service.name";' DataFusion CLI v33.0.0 +---------------------------------+----------------------------------+ | COUNT(DISTINCT traces.trace_id) | COUNT(DISTINCT traces.span.kind) | +---------------------------------+----------------------------------+ | 30714 | 1 | | 30678 | 1 | | 30714 | 1 | | 30678 | 1 | | 30673 | 1 | | 3632710 | 2 | +---------------------------------+----------------------------------+ 6 rows in set. Query took 1.771 seconds. ``` And I verified (by putting a println in ) that this build array was getting called -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
