tustvold commented on PR #5180: URL: https://github.com/apache/arrow-rs/pull/5180#issuecomment-1845432515
> AFAICT the way the proposed ordering relation works will not break any sorts. Since indeterminate cases return false all ways, it will act like a pseudo total order. This is what I'm trying to nail down by discussing with you -- if it breaks sorts, I agree it is a no-go. Currently the following is always true regardless of input ``` let sorted = sort(input, None).unwrap(); let len_one = sorted.len() - 1; let comparison = lt_eq(&sorted.slice(0, len_one), &sorted.slice(1, len_one)).unwrap(); assert_eq!(comparison.true_count(), len_one) ``` Or to put it differently the arrow library uses a consistent total ordering relation across its kernels, including things like the row format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
