davisusanibar commented on code in PR #38423:
URL: https://github.com/apache/arrow/pull/38423#discussion_r1419063634
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowReader.java:
##########
@@ -242,6 +247,9 @@ protected void loadDictionary(ArrowDictionaryBatch
dictionaryBatch) {
VectorBatchAppender.batchAppend(vector, deltaVector);
}
return;
+ } else if (validateReplacements && getClass() == ArrowFileReader.class) {
+ throw new IllegalStateException("Replacement dictionaries are not
supported in " +
+ "the IPC file format. Dictionary ID: " +
dictionary.getEncoding().getId());
Review Comment:
Would it be possible to include these new changes/updates in the IPC
documentation file -> docs/source/java/ipc.rst#reading-writing-ipc-formats?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
