AdamGS commented on code in PR #5183:
URL: https://github.com/apache/arrow-rs/pull/5183#discussion_r1419142048
##########
parquet/src/column/writer/mod.rs:
##########
@@ -329,28 +329,11 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a,
E> {
None => values.len(),
};
- // If only computing chunk-level statistics compute them here,
page-level statistics
- // are computed in [`Self::write_mini_batch`] and used to update chunk
statistics in
- // [`Self::add_data_page`]
- if self.statistics_enabled == EnabledStatistics::Chunk
Review Comment:
Defiantly simpler than #5181 IMO. Having less places that do
`update_min/update_max(...)` on the column's stats makes it much easier to
follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
