tustvold commented on code in PR #5184:
URL: https://github.com/apache/arrow-rs/pull/5184#discussion_r1419266442
##########
arrow-ord/src/comparison.rs:
##########
@@ -243,64 +243,6 @@ fn make_utf8_scalar(d: &DataType, scalar: &str) ->
Result<ArrayRef, ArrowError>
}
}
-/// Helper function to perform boolean lambda function on values from two
array accessors, this
-/// version does not attempt to use SIMD.
-fn compare_op<T: ArrayAccessor, S: ArrayAccessor, F>(
- left: T,
- right: S,
- op: F,
-) -> Result<BooleanArray, ArrowError>
-where
- F: Fn(T::Item, S::Item) -> bool,
-{
- if left.len() != right.len() {
- return Err(ArrowError::ComputeError(
- "Cannot perform comparison operation on arrays of different
length".to_string(),
- ));
- }
-
- Ok(BooleanArray::from_binary(left, right, op))
-}
-
-/// Helper function to perform boolean lambda function on values from array
accessor, this
-/// version does not attempt to use SIMD.
-fn compare_op_scalar<T: ArrayAccessor, F>(left: T, op: F) ->
Result<BooleanArray, ArrowError>
-where
- F: Fn(T::Item) -> bool,
-{
- Ok(BooleanArray::from_unary(left, op))
-}
-
-/// Evaluate `op(left, right)` for [`PrimitiveArray`]s using a specified
-/// comparison function.
-#[deprecated(note = "Use BooleanArray::from_binary")]
-pub fn no_simd_compare_op<T, F>(
Review Comment:
I opted to just remove these as the no_simd was confusing in the abscence of
an explicit SIMD version, and they were deprecated already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
