paleolimbot commented on issue #1348: URL: https://github.com/apache/arrow-adbc/issues/1348#issuecomment-1846065549
This was almost certainly my fault (see linked PRs for errors that might have contributed to this). After #1334 + https://github.com/apache/arrow-nanoarrow/pull/333 I get: ``` r ctx <- DBItest::make_context( adbi::adbi("adbcsqlite"), list( uri = tempfile("DBItest", fileext = ".sqlite") ), tweaks = suppressWarnings( DBItest::tweaks( dbitest_version = "1.7.3", constructor_relax_args = TRUE, placeholder_pattern = c("?", "$1", "$name", ":name"), date_cast = function(x) paste0("'", x, "'"), time_cast = function(x) paste0("'", x, "'"), timestamp_cast = function(x) paste0("'", x, "'"), logical_return = function(x) bit64::as.integer64(x), date_typed = FALSE, time_typed = FALSE, timestamp_typed = FALSE, temporary_tables = FALSE, # apache/arrow-adbc#1141 strict_identifier = TRUE ) ), name = "adbi" ) DBItest::test_some("bind_repeated", ctx, FALSE) #> ── Skip ('/private/var/folders/k4/0jwzxmln0nb8y6rkzprptb640000gq/T/RtmpRvwdmX/R.INSTALLe0b0449f71f1/DBItest/R/run.R:77:11'): DBItest[adbi]: Metadata: bind_repeated ── #> Reason: TODO: unknown number of `rows_affected` ``` ...but running all the tests, I get: ``` ── Failed tests ──────────────────────────────────────────────── Error (/private/var/folders/k4/0jwzxmln0nb8y6rkzprptb640000gq/T/RtmpRvwdmX/R.INSTALLe0b0449f71f1/DBItest/R/run.R:77:11): DBItest[adbi]: SQL: remove_table_other_con <adbc_error_child_count_not_zero/simpleError/error/condition> Error in `adbcdrivermanager::adbc_connection_release(conn@connection)`: <adbcsqlite_connection/adbc_connection/adbc_xptr> has 2 unreleased child objects Backtrace: ▆ 1. ├─rlang::exec(test_fun, !!!args) at DBItest/R/run.R:77:11 2. └─DBItest (local) `<fn>`(ctx = `<DBItst_c>`, con = `<AdbCnnct>`, table_name = "dbitojlsgzcvjr") 3. └─withr (local) `<fn>`(`<env>`) [ FAIL 1 | WARN 0 | SKIP 170 | PASS 2870 ] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
