alamb commented on issue #8436: URL: https://github.com/apache/arrow-datafusion/issues/8436#issuecomment-1846124551
> I think we can use Short-circuit evaluation here, if left satisfy some condition, we can skip right. > I am in the middle of rewriting the bloom filter implementation to be more general (see https://github.com/apache/arrow-datafusion/pull/8442). I believe the new (not yet merged) code correctly handles predicates like `where trace_id='3c7dbf90d1a66e3faffa344519c3bac3' OR trace_id='1' OR trace_id='2' OR trace_id='3'` However, the new code does not handle explicit `IN` expressions This ticket was perhaps a bit over eager -- basically I recommend not changing the existing implementation as I am rewriting it. However, if you would like to that is fine, I can update the change as part of my PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
