mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r560636760
##########
File path: cpp/src/arrow/adapters/orc/adapter_util.cc
##########
@@ -425,6 +907,139 @@ Status GetArrowType(const liborc::Type* type,
std::shared_ptr<DataType>* out) {
return Status::OK();
}
+Status GetORCType(const DataType* type, ORC_UNIQUE_PTR<liborc::Type>* out) {
+ // Check for NULLPTR
+ if (type == NULLPTR) {
Review comment:
This does need to be removed. We don’t need to add a feature to write NA
type Arrow columns into ORC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
