Weijun-H commented on code in PR #8454:
URL: https://github.com/apache/arrow-datafusion/pull/8454#discussion_r1420125094
##########
datafusion/core/src/physical_optimizer/projection_pushdown.rs:
##########
@@ -265,6 +290,12 @@ fn try_unifying_projections(
.map(|e| Some(Arc::new(e) as _))
}
+// check if the expr trival
Review Comment:
nit:
```suggestion
/// Checks if the given expression is trivial.
/// An expression is considered trivial if it is either a `Column` or a
`Literal`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]