tustvold commented on code in PR #5191:
URL: https://github.com/apache/arrow-rs/pull/5191#discussion_r1420520365
##########
arrow-array/src/array/boolean_array.rs:
##########
@@ -254,6 +254,11 @@ impl BooleanArray {
});
Self::new(values, nulls)
}
+
+ /// Deconstruct this array into its constituent parts
+ pub fn into_parts(self) -> (DataType, BooleanBuffer, Option<NullBuffer>) {
Review Comment:
I think this should mirror the constructor and therefore not return DataType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
