CurtHagenlocher commented on code in PR #39146:
URL: https://github.com/apache/arrow/pull/39146#discussion_r1420801623
##########
csharp/src/Apache.Arrow/Ipc/ArrowFileReaderImplementation.cs:
##########
@@ -35,12 +35,14 @@ internal sealed class ArrowFileReaderImplementation :
ArrowStreamReaderImplement
private ArrowFooter _footer;
+ private bool HasReadDictionaries => HasReadSchema &&
DictionaryMemo.LoadedDictionaryCount >= _footer.DictionaryCount;
+
public ArrowFileReaderImplementation(Stream stream, MemoryAllocator
allocator, ICompressionCodecFactory compressionCodecFactory, bool leaveOpen)
: base(stream, allocator, compressionCodecFactory, leaveOpen)
{
}
- public async ValueTask<int> RecordBatchCountAsync()
+ public async ValueTask<int> RecordBatchCountAsync(CancellationToken
cancellationToken = default)
Review Comment:
Undo this; I filed a separate work item to track cancellation tokens not
flowing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
