mustafasrepo opened a new pull request, #8484:
URL: https://github.com/apache/arrow-datafusion/pull/8484

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Improves the situation on #8064.
   
   ## Rationale for this change
   
   In the [PR8281](https://github.com/apache/arrow-datafusion/pull/8281) we 
added support for ordering requirement analysis for complex expressions.
   
   However, in current codebase some ordering information got lost during the 
projection of complex expressions.
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   ## What changes are included in this PR?
   This PR adds support for better ordering information propagation support for 
complex expressions through `ProjectionExec`.
   Consider the case where we have table with columns `a,b,c,d,e` and assume 
that `[a ASC, b ASC]`, `[c ASC]` is valid orderings for this table.
   
   If were to apply the projection (a, c, b+c) on top of this table valid 
orderings after projection are: `[a ASC, b+c ASC]`, `[c ASC]`. However, in 
current code base we can propagate only `[a ASC]`, `[c ASC]`. This PR enables 
us to propagate complex expression orderings better through `ProjectionExec`. 
You can examine unit tests for other examples of this PR's support.
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## Are these changes tested?
   Yes extensive unit and random test is added. Most of the changes comes from 
test or test util codes.
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to