alamb commented on issue #8216: URL: https://github.com/apache/arrow-datafusion/issues/8216#issuecomment-1849992841
> @alamb Hello, all tests are added to https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest/test_files ? Yes perhaps in `timestamp.slt` or something similar I think part of the reason there are many old tests is that the tests predate `arrow_cast` so the setup of the data took quite a lot more code. Using `arrow_cast(col, Timestamp(Nanosecond, None))` type calls should reduce the code significatnly > The number of tests seems to be quite large Indeed -- perhaps you could pick one or two tests to port over initially rather than trying to it all in a single PR. That would let us provide incremental feedback along the way as well and make reviewing the PRs easier as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
