lidavidm commented on code in PR #39171:
URL: https://github.com/apache/arrow/pull/39171#discussion_r1422564020
##########
java/flight/flight-core/src/test/java/org/apache/arrow/flight/FlightTestUtil.java:
##########
@@ -47,7 +48,11 @@ static Path exampleTlsRootCert() {
static List<CertKeyPair> exampleTlsCerts() {
final Path root = getFlightTestDataRoot();
- return Arrays.asList(new CertKeyPair(root.resolve("cert0.pem").toFile(),
root.resolve("cert0.pkcs1").toFile()),
+ final Path cert0Pem = root.resolve("cert0.pem");
+ if (!Files.exists(cert0Pem)) {
+ throw new RuntimeException(cert0Pem + " doesn't exist. Take a look on
https://arrow.apache.org/docs/dev/developers/java/building.html#building to
initialize.");
Review Comment:
```suggestion
throw new RuntimeException(cert0Pem + " doesn't exist. Make sure
submodules are initialized (see
https://arrow.apache.org/docs/dev/developers/java/building.html#building)");
```
##########
java/flight/flight-core/src/test/java/org/apache/arrow/flight/FlightTestUtil.java:
##########
@@ -47,7 +48,11 @@ static Path exampleTlsRootCert() {
static List<CertKeyPair> exampleTlsCerts() {
final Path root = getFlightTestDataRoot();
- return Arrays.asList(new CertKeyPair(root.resolve("cert0.pem").toFile(),
root.resolve("cert0.pkcs1").toFile()),
+ final Path cert0Pem = root.resolve("cert0.pem");
+ if (!Files.exists(cert0Pem)) {
+ throw new RuntimeException(cert0Pem + " doesn't exist. Take a look on
https://arrow.apache.org/docs/dev/developers/java/building.html#building to
initialize.");
Review Comment:
Something like this, in case the user already knows git?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
