AlenkaF commented on PR #39112: URL: https://github.com/apache/arrow/pull/39112#issuecomment-1850541037
It is very hard to review this PR due to the way the diff is presented in GitHub. I tried to summarise the main changes in the description of the PR, hope it helps a bit. @jorisvandenbossche after the last review I have updated the marks in the tests, added `use_legacy_dataset=None` to `ParquetDataset` class, `read_table` and `arite_to_dataset`. I have also removed `** kwargs` from `ParquetDataset`, previously `_ParquetDatasetV2`, which meant I had to remove the code connected to `metadata`, `split_row_groups` and `validate_schema` ([raising an error](https://github.com/apache/arrow/blob/92e56ba8906f40996cc81bc09fca10c4d53b32fa/python/pyarrow/parquet/core.py#L2441-L2448)) and so I added a note in the docstrings https://github.com/apache/arrow/pull/39112/commits/b6799cfbe68a3289e00378739bc5291ff81d8855. Not sure if that is well done though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
