jayzhan211 commented on code in PR #8496:
URL: https://github.com/apache/arrow-datafusion/pull/8496#discussion_r1423277946
##########
datafusion/sql/src/expr/binary_op.rs:
##########
@@ -47,6 +47,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
BinaryOperator::PGBitwiseShiftRight =>
Ok(Operator::BitwiseShiftRight),
BinaryOperator::PGBitwiseShiftLeft =>
Ok(Operator::BitwiseShiftLeft),
BinaryOperator::StringConcat => Ok(Operator::StringConcat),
+ BinaryOperator::PGOverlap => Ok(Operator::And),
Review Comment:
btw PGOverlap does not seem pg specific, although the comment said. It is
also parsed in GenericDialect. Is the comment misleading or what? 🤔
https://github.com/sqlparser-rs/sqlparser-rs/blob/8d97330d42fa9acf63d8bf6412b762948e025496/src/parser/mod.rs#L2106-L2107
##########
datafusion/sql/src/expr/binary_op.rs:
##########
@@ -47,6 +47,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
BinaryOperator::PGBitwiseShiftRight =>
Ok(Operator::BitwiseShiftRight),
BinaryOperator::PGBitwiseShiftLeft =>
Ok(Operator::BitwiseShiftLeft),
BinaryOperator::StringConcat => Ok(Operator::StringConcat),
+ BinaryOperator::PGOverlap => Ok(Operator::And),
Review Comment:
btw PGOverlap does not seem pg specific, although the comment said. It is
also parsed in GenericDialect. Is the comment misleading or what? 🤔
https://github.com/sqlparser-rs/sqlparser-rs/blob/8d97330d42fa9acf63d8bf6412b762948e025496/src/parser/mod.rs#L2106-L2107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
