comphead commented on code in PR #8402:
URL: https://github.com/apache/arrow-datafusion/pull/8402#discussion_r1423304116
##########
datafusion/sql/src/expr/function.rs:
##########
@@ -90,10 +91,30 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let partition_by = window
.partition_by
.into_iter()
+ // ignore window spec PARTITION BY for scalar values
+ .filter(|e| !matches!(e, sqlparser::ast::Expr::Value { .. }))
.map(|e| self.sql_expr_to_logical_expr(e, schema,
planner_context))
.collect::<Result<Vec<_>>>()?;
- let order_by =
- self.order_by_to_sort_expr(&window.order_by, schema,
planner_context)?;
+
+ let order_by = self.order_by_to_sort_expr(
+ &window
+ .order_by
+ .into_iter()
+ // ignore window spec ORDER BY for scalar values
+ .filter(|e| {
+ !matches!(
+ e,
+ OrderByExpr {
+ expr: sqlparser::ast::Expr::Value { .. },
+ ..
+ }
+ )
Review Comment:
@mustafasrepo can I have your input please. The reason is the query fails
```
select rank() over (order by 1) rnk from (select 1 a union all select 2 a) x
Arrow error: Invalid argument error: number of columns(2) must match number
of fields(1) in schema
```
The reason for that is `optimize_projections` removes the unused fields and
this breaks the consistency. The question for you, what do you think is
expected behavior for such rare case?
PS. If add a column name to projection or to ORDER BY it will expectedly
work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
