haohuaijin commented on code in PR #8485:
URL: https://github.com/apache/arrow-datafusion/pull/8485#discussion_r1423603501
##########
datafusion/core/src/physical_optimizer/projection_pushdown.rs:
##########
@@ -454,7 +454,8 @@ fn try_swapping_with_sort(
Ok(Some(Arc::new(
SortExec::new(updated_exprs, make_with_child(projection,
sort.input())?)
Review Comment:
I wonder if we can remove the `preserve_partitioning` parameters because the
description of `preserve_partitioning` is not correct now and seem like no
sense.
https://github.com/apache/arrow-datafusion/blob/95ba48bd2291dd5c303bdaf88cbb55c79d395930/datafusion/physical-plan/src/sorts/sort.rs#L726-L732
what ever set `preserve_partitioning` true or false, we only sort each
partition individually. And the merge work is done in `SortPreservingMergeExec`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
