tustvold commented on code in PR #5196:
URL: https://github.com/apache/arrow-rs/pull/5196#discussion_r1424337619


##########
arrow-csv/src/writer.rs:
##########
@@ -193,6 +193,12 @@ pub struct WriterBuilder {
     delimiter: u8,
     /// Whether to write column names as file headers. Defaults to `true`
     has_header: bool,
+    /// Optional quote character. Defaults to `b'"'`
+    quote: u8,
+    /// Optional escape character. Defaults to `b'\\'`
+    escape: u8,

Review Comment:
   I think this needs to be an option, that is by default None. Otherwise as 
written this enables escapes by default, which we definitely do not want?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to