bkietz commented on code in PR #38252:
URL: https://github.com/apache/arrow/pull/38252#discussion_r1424346662
##########
cpp/src/arrow/extension_type.h:
##########
@@ -43,7 +43,7 @@ class ARROW_EXPORT ExtensionType : public DataType {
static constexpr const char* type_name() { return "extension"; }
/// \brief The type of array used to represent this extension type's data
- const std::shared_ptr<DataType>& storage_type() const { return
storage_type_; }
+ std::shared_ptr<DataType> storage_type() const override { return
storage_type_; }
Review Comment:
I intended to remove storage_type_ref altogether
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
