viirya commented on code in PR #8520: URL: https://github.com/apache/arrow-datafusion/pull/8520#discussion_r1424479504
########## datafusion/sqllogictest/test_files/functions.slt: ########## @@ -995,3 +995,8 @@ query ? SELECT find_in_set(NULL, NULL) ---- NULL + +query B +SELECT r1 == r2 FROM (SELECT random() r1, random() r2) +---- +false Review Comment: Ah, yea, I actually did `SELECT r1 == r2, r1, r2 FROM (SELECT random() r1, random() r2)` locally, but r1, r2 is random so it will be changed. So I removed r1, r2. Seems DataFusion does some optimization so it returns true. Let me think how to test it properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
