jorgecarleitao commented on pull request #9235: URL: https://github.com/apache/arrow/pull/9235#issuecomment-763878812
I validated that with @mbrubeck 's change, we can just use `collect` and drop the `trusted_len` and `unsafe` hack with the same performance on the arithmetics 🎉 🎉🎉 @mbrubeck , thank you so much for taking your time in addressing this; I have been really struggling with the compiler on this one and your implementation is exactly what I was trying to achieve in this PR: an efficient, `safe`, and expressive API for our users to build a `MutableBuffer`. When we commit to master we squash all commits. Would you be willing to take credit for this whole PR + your changes? IMO the most relevant part of this whole thing was your change, that enables `collect`. Alternatively, we could merge this PR as is, and then apply your changes on a separate one. Let me know what you prefer I will act accordingly (@alamb let me know if you see any problem here). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
