tgujar commented on code in PR #8363:
URL: https://github.com/apache/arrow-datafusion/pull/8363#discussion_r1424650638
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1005,6 +1035,55 @@ pub async fn from_substrait_rex(
},
})))
}
+ Some(RexType::Subquery(subquery)) => match
&subquery.as_ref().subquery_type {
+ Some(subquery_type) => match subquery_type {
+ SubqueryType::InPredicate(in_predicate) => {
+ if in_predicate.needles.len() != 1 {
+ Err(DataFusionError::Substrait(
+ "InPredicate Subquery type must have exactly one
Needle expression"
+ .to_string(),
+ ))
+ } else {
+ let needle_expr = &in_predicate.needles[0];
+ let haystack_expr = &in_predicate.haystack;
+ if let Some(haystack_expr) = haystack_expr {
+ let haystack_expr =
+ from_substrait_rel(ctx, haystack_expr,
extensions)
Review Comment:
Similar to producer, I needed to add `ctx` here and the added argument for
`ctx` in other functions is to support calling `from_substrait_rel` recursively
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
