felipecrv commented on code in PR #39207:
URL: https://github.com/apache/arrow/pull/39207#discussion_r1424771319
##########
cpp/src/arrow/filesystem/azurefs_test.cc:
##########
@@ -158,25 +215,39 @@ class AzuriteEnv : public ::testing::Environment {
std::cerr << std::endl;
return Status::OK();
}
+};
- const std::string& account_name() const { return account_name_; }
- const std::string& account_key() const { return account_key_; }
- const Status status() const { return status_; }
-
+class AzureFlatNSEnv : public AzureEnvImpl<AzureFlatNSEnv> {
private:
- std::string account_name_;
- std::string account_key_;
- bp::child server_process_;
- Status status_;
Review Comment:
No more awkward `status_` being set on ctor now that `Make` is used to
construct the environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
