ryan-syed opened a new pull request, #1352:
URL: https://github.com/apache/arrow-adbc/pull/1352

   fix: Reduced SQL calls in GetObjects to two, added prefixing DbName for 
INFORMATION_SCHEMA calls, and removed SQL cursor code
   
   Additional changes:
   * Reduced SQL calls by making only 1 - 2 SQL call based on the ObjectsDepth 
and using that data to populate all the previous depth information
   * There is one SHOW TERSE DATABASES that is always called and the 
catalogPattern is used to filter the databases and prepare the SQL based on the 
depth for schema, tables, or columns 
   * The SQL cursor code was removed and the replaced with a static SQL that is 
prepared in Go based on the databases that match the catalogPattern
   * GetObjects populates the MetadataRecords by making the necessary SQL call 
based on ObjectsDepth
   * Modified the logic of GetObjects Init to pass MetadataRecords in 
getObjectsDbSchemas and getObjectsTables
   * Modified tests to check the table type returned
   
   
![image](https://github.com/apache/arrow-adbc/assets/5041197/2542eca0-ea74-44e9-a78a-51c571c8c0ab)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to