mustafasrepo commented on PR #8525: URL: https://github.com/apache/arrow-datafusion/pull/8525#issuecomment-1855200510
> Quite curious, if the test is not deterministic, why we did not fail on this test before? > > Oh, I think probably because of `set datafusion.execution.target_partitions = 1;` > > Maybe we can remove unneccessary `set datafusion.execution.target_partitions = 1;` before test, so we know what test need specific setting easily. Yes, because setting is not random. Results are deterministicat each run. However, also in terms of query specifications some results are not certain. For instance for the query ```sql SELECT DISTINCT ON (c1) c1, c2 FROM aggregate_test_100 ORDER BY c1, c3; ``` Both ``` a 5 b 4 c 2 d 1 e 3 ``` and ``` a 4 b 4 c 2 d 1 e 3 ``` are valid. However for query ```sql SELECT DISTINCT ON (c1) c1, c2 FROM aggregate_test_100 ORDER BY c1, c3, c9; ``` only valid result is ``` a 4 b 4 c 2 d 1 e 3 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
