tustvold commented on code in PR #5188:
URL: https://github.com/apache/arrow-rs/pull/5188#discussion_r1426439316
##########
object_store/src/gcp/builder.rs:
##########
@@ -107,7 +107,7 @@ pub struct GoogleCloudStorageBuilder {
retry_config: RetryConfig,
/// Client options
client_options: ClientOptions,
- /// Credentials
+ /// Credentials. Uses instance metadata credentials if not provided
Review Comment:
This won't be rendered on docs.rs as this is a private field, perhaps we
could document on the struct, i.e. line 84
##########
object_store/src/gcp/builder.rs:
##########
@@ -393,7 +393,6 @@ impl GoogleCloudStorageBuilder {
self
}
- /// Set the credential provider overriding any other options
Review Comment:
Why this removal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
