alamb commented on PR #5209: URL: https://github.com/apache/arrow-rs/pull/5209#issuecomment-1856132947
🤔 @tustvold and @Dandandan hvae points out that the overhead of copying NullBuffers is probably small https://github.com/apache/arrow-rs/blob/802ed428f87051fdca31180430ddb0ecb2f60e8b/arrow-buffer/src/buffer/null.rs#L30C15-L33 The size of a NullBuffer is 48 bytes. ```rust println!("sizeof null buffer: {}", std::mem::size_of::<NullBuffer>()); ``` ``` sizeof null buffer: 48 ``` So this PR would save copying 48 bytes and 1 atomic increment for the common case where the null buffer is not computed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
