alamb commented on pull request #9261: URL: https://github.com/apache/arrow/pull/9261#issuecomment-764604319
@vertexclique -- this is really cool. Thank you So now I notice that the MIRI check is flagging what is presumably an error. Is that something you are planning to fix? If not I might be able to find some time to do so https://github.com/apache/arrow/pull/9261/checks?check_run_id=1729267740 ``` test array::builder::tests::test_string_dictionary_builder_with_reserved_null_value ... ok error: Undefined Behavior: trying to reborrow for SharedReadWrite at alloc8703298, but parent tag <23938158> does not have an appropriate item in the borrow stack --> arrow/src/array/builder.rs:1460:9 | 1460 | self.field_anys[i].downcast_mut::<T>() | ^^^^^^^^^^^^^^^^^^ trying to reborrow for SharedReadWrite at alloc8703298, but parent tag <23938158> does not have an appropriate item in the borrow stack | = help: this indicates a potential bug in the program: it performed an invalid operation, but the rules it violated are still experimental = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information = note: inside `array::builder::StructBuilder::field_builder::<array::builder::GenericStringBuilder<i32>>` at arrow/src/array/builder.rs:1460:9 note: inside `array::builder::tests::test_struct_array_builder` at arrow/src/array/builder.rs:2827:30 --> arrow/src/array/builder.rs:2827:30 | 2827 | let string_builder = builder | ______________________________^ 2828 | | .field_builder::<StringBuilder>(0) | |______________________________________________^ note: inside closure at arrow/src/array/builder.rs:2813:5 --> arrow/src/array/builder.rs:2813:5 | 2813 | / fn test_struct_array_builder() { 2814 | | let string_builder = StringBuilder::new(4); 2815 | | let int_builder = Int32Builder::new(4); 2816 | | ... | 2892 | | } 2893 | | } | |_____^ = note: inside `<[closure@arrow/src/array/builder.rs:2813:5: 2893:6] as std::ops::FnOnce<()>>::call_once - shim` at /usr/share/rust/.rustup/toolchains/nightly-2021-01-19-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
