alamb commented on PR #8480: URL: https://github.com/apache/arrow-datafusion/pull/8480#issuecomment-1856313139
> LGTM in DataFusion context, thank you @alamb > > Just a question -- it doesn't look like a big deal for this one, but is it fine to remove [public constant](https://docs.rs/datafusion-expr/latest/datafusion_expr/struct_expressions/static.SUPPORTED_STRUCT_TYPES.html) provided by crate without deprecating it first? That is a good question @korowa -- I think it is a judgement call based on if we think removing the `pub` thing is likely to be encountered during upgrade and if the API change will be hard to adjust to for users. In this case I don't think it will have a big impact, though I fully admit I have no data one way or the other -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
