alamb commented on code in PR #8537:
URL: https://github.com/apache/arrow-datafusion/pull/8537#discussion_r1427215688
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -487,10 +483,10 @@ impl AggregateExec {
));
let original_schema = Arc::new(original_schema);
// Reset ordering requirement to `None` if aggregator is not
order-sensitive
- order_by_expr = aggr_expr
+ let mut order_by_expr = aggr_expr
Review Comment:
This is the key observation, right? That the ordering can be derived from
the `AggregateExprs` themselves
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
