l45k opened a new issue, #8554:
URL: https://github.com/apache/arrow-datafusion/issues/8554

   ### Is your feature request related to a problem or challenge?
   
   I would like to build a custom aggregator based on the 
[tdigest](https://github.com/apache/arrow-datafusion/blob/main/datafusion/physical-expr/src/aggregate/tdigest.rs).
 The tdigest `mod` is private, and thus I can't use it outside DataFusion. It 
would be great if it would be changed to poublic to allow custom aggregators 
based on it.
   
   ### Describe the solution you'd like
   
   To allow building new aggregators based on the `tdigest` make it public by 
changing the following
   
https://github.com/apache/arrow-datafusion/blob/b276d479918400105017db1f7f46dcb67b52206d/datafusion/physical-expr/src/aggregate/mod.rs#L58
   to 
   ```rust
   pub mod tdigest
   ```
   
   ### Describe alternatives you've considered
   
   If changing the visibility to public is not possible, I would need to 
introduce my own tdigest and reproduce a lot of code to make it work as an 
aggregator. This also means that I need to update the code with each new 
version of DataFusion.
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to