Weijun-H commented on code in PR #8494: URL: https://github.com/apache/arrow-datafusion/pull/8494#discussion_r1427724263
########## datafusion/sqllogictest/test_files/options.slt: ########## @@ -147,7 +147,7 @@ select .0 as c1, 0. as c2, 0000. as c3, 00000.00 as c4 query TTTT select arrow_typeof(.0) as c1, arrow_typeof(0.) as c2, arrow_typeof(0000.) as c3, arrow_typeof(00000.00) as c4 ---- -Decimal128(1, 1) Decimal128(1, 0) Decimal128(1, 0) Decimal128(2, 2) +Decimal128(2, 1) Decimal128(1, 0) Decimal128(1, 0) Decimal128(3, 2) Review Comment: Previous tests are not correct ########## datafusion/sqllogictest/test_files/options.slt: ########## @@ -147,7 +147,7 @@ select .0 as c1, 0. as c2, 0000. as c3, 00000.00 as c4 query TTTT select arrow_typeof(.0) as c1, arrow_typeof(0.) as c2, arrow_typeof(0000.) as c3, arrow_typeof(00000.00) as c4 ---- -Decimal128(1, 1) Decimal128(1, 0) Decimal128(1, 0) Decimal128(2, 2) +Decimal128(2, 1) Decimal128(1, 0) Decimal128(1, 0) Decimal128(3, 2) Review Comment: ```bash D select cast(.0 as decimal(2,1)); ┌──────────────────────────┐ │ CAST(.0 AS DECIMAL(2,1)) │ ├──────────────────────────┤ │ 0.0 │ └──────────────────────────┘ D select cast(.0 as decimal(1,1)); ┌──────────────────────────┐ │ CAST(.0 AS DECIMAL(1,1)) │ ├──────────────────────────┤ │ .0 │ └──────────────────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
