bkietz commented on code in PR #39019:
URL: https://github.com/apache/arrow/pull/39019#discussion_r1427990144
##########
go/arrow/internal/arrjson/arrjson.go:
##########
@@ -1090,7 +1091,7 @@ func arrayFromJSON(mem memory.Allocator, dt
arrow.DataType, arr Array) arrow.Arr
case arrow.BinaryViewDataType:
valids := validsToBitmap(validsFromJSON(arr.Valids), mem)
nulls := arr.Count - bitutil.CountSetBits(valids.Bytes(), 0,
arr.Count)
- headers := stringHeadersFromJSON(mem, !dt.IsUtf8(), arr.Data)
+ headers := stringHeadersFromJSON(mem, !dt.IsUtf8(), arr.Views)
Review Comment:
Nope, will add
##########
go/arrow/cdata/cdata.go:
##########
@@ -654,6 +680,40 @@ func (imp *cimporter) importStringLike(offsetByteWidth
int64) (err error) {
return
}
+func (imp *cimporter) importBinaryViewLike() (err error) {
+ if err = imp.checkNoChildren(); err != nil {
+ return
+ }
+
+ buffers := make([]*memory.Buffer, len(imp.cbuffers)-1)
+ // XXX couldn't figure out how to extract
file_reader.go::releaseBuffers as a utility
+ defer func() {
+ for _, buf := range buffers {
+ if buf != nil {
+ buf.Release()
+ }
+ }
+ }()
Review Comment:
I'll try that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
