jayzhan211 commented on code in PR #8561:
URL: https://github.com/apache/arrow-datafusion/pull/8561#discussion_r1428621263
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -524,11 +525,33 @@ pub fn array_except(args: &[ArrayRef]) ->
Result<ArrayRef> {
///
/// See test cases in `array.slt` for more details.
pub fn array_slice(args: &[ArrayRef]) -> Result<ArrayRef> {
- let list_array = as_list_array(&args[0])?;
- let from_array = as_int64_array(&args[1])?;
- let to_array = as_int64_array(&args[2])?;
+ let array_data_type = args[0].data_type();
+ match array_data_type {
+ DataType::List(_) => {
+ let array = as_list_array(&args[0])?;
+ let from_array = as_int64_array(&args[1])?;
+ let to_array = as_int64_array(&args[2])?;
+ general_array_slice::<i32, Int64Type>(array, from_array, to_array)
+ }
+ DataType::LargeList(_) => {
+ let array = as_large_list_array(&args[0])?;
+ let from_array = as_int64_array(&args[1])?;
+ let to_array = as_int64_array(&args[2])?;
+ general_array_slice::<i64, Int64Type>(array, from_array, to_array)
+ }
+ _ => not_impl_err!("array_slice does not support type: {:?}",
array_data_type),
+ }
+}
- let values = list_array.values();
+fn general_array_slice<O: OffsetSizeTrait, T: ArrowNumericType<Native = i64>>(
+ array: &GenericListArray<O>,
+ from_array: &PrimitiveArray<T>,
Review Comment:
How about use In64Aray?
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -524,11 +525,33 @@ pub fn array_except(args: &[ArrayRef]) ->
Result<ArrayRef> {
///
/// See test cases in `array.slt` for more details.
pub fn array_slice(args: &[ArrayRef]) -> Result<ArrayRef> {
- let list_array = as_list_array(&args[0])?;
- let from_array = as_int64_array(&args[1])?;
- let to_array = as_int64_array(&args[2])?;
+ let array_data_type = args[0].data_type();
+ match array_data_type {
+ DataType::List(_) => {
+ let array = as_list_array(&args[0])?;
+ let from_array = as_int64_array(&args[1])?;
+ let to_array = as_int64_array(&args[2])?;
+ general_array_slice::<i32, Int64Type>(array, from_array, to_array)
+ }
+ DataType::LargeList(_) => {
+ let array = as_large_list_array(&args[0])?;
+ let from_array = as_int64_array(&args[1])?;
+ let to_array = as_int64_array(&args[2])?;
+ general_array_slice::<i64, Int64Type>(array, from_array, to_array)
+ }
+ _ => not_impl_err!("array_slice does not support type: {:?}",
array_data_type),
+ }
+}
- let values = list_array.values();
+fn general_array_slice<O: OffsetSizeTrait, T: ArrowNumericType<Native = i64>>(
+ array: &GenericListArray<O>,
+ from_array: &PrimitiveArray<T>,
Review Comment:
How about use Int64Aray?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
