domoritz commented on PR #39018: URL: https://github.com/apache/arrow/pull/39018#issuecomment-1859023980
Can you update it to add support for the new LargeUTF8 type? Did you see any differences in the benchmark suite? I wonder whether it would be worth using singletons for common/primitive types. But that's orthogonal to this pull request and I am happy to merge if the benchmarks don't show huge differences. I don't really trust this but https://conbench.ursa.dev/compare/runs/2d46394a52e04edab18a051c253c317d...3d356a645a664215934860d5a54e1828/ shows some big differences (where this is faster ????) <img width="1351" alt="Screenshot 2023-12-16 at 22 11 27" src="https://github.com/apache/arrow/assets/589034/8537ac84-5bcf-42dc-9bdd-d4d856cfdcfe";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
