alamb commented on code in PR #8046:
URL: https://github.com/apache/arrow-datafusion/pull/8046#discussion_r1398507105
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -1228,30 +1229,4 @@ mod test {
unreachable!();
}
}
-
- #[test]
- fn encode_function_definitions() {
Review Comment:
I don't think these tests add a lot -- they simply encode the signature
again . A better test is to actually call `encode()` via the expr API /
dataframe tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
