metesynnada commented on code in PR #8573:
URL: https://github.com/apache/arrow-datafusion/pull/8573#discussion_r1429610238
##########
datafusion/core/src/physical_optimizer/replace_with_order_preserving_variants.rs:
##########
Review Comment:
I think test logic may depend on infinite sources. So, we can use an
unbounded executor like `StreamingTableExec` to preserve the test logic.
##########
datafusion/core/src/physical_optimizer/test_utils.rs:
##########
@@ -54,14 +55,19 @@ async fn register_current_csv(
) -> Result<()> {
let testdata = crate::test_util::arrow_test_data();
let schema = crate::test_util::aggr_test_schema();
- ctx.register_csv(
- table_name,
- &format!("{testdata}/csv/aggregate_test_100.csv"),
- CsvReadOptions::new()
- .schema(&schema)
- .mark_infinite(infinite),
- )
- .await?;
+ let path = format!("{testdata}/csv/aggregate_test_100.csv");
+
+ match infinite {
Review Comment:
👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
