alamb commented on issue #8572: URL: https://github.com/apache/arrow-datafusion/issues/8572#issuecomment-1860226735
I believe it was a deliberate change. from the comment you reference https://github.com/apache/arrow-datafusion/pull/7671#discussion_r1341636365 > For some detailed context: The flag basically lets the user choose whether they want SortPreservingMerges, or Repartition/Coalesce+Sort cascades. We ran some benchmarks and there is no clearly dominating strategy, each alternative comes out ahead in certain cases. In non-streaming cases, the first alternative typically came out ahead, so we let the default flag value to be false. In IOx it is better for our usecase to use pre-existing sort orders, but I can see how for other uses cases it may not be. If there is a consensus that changing the default setting would be less surprising, it would be fine with me to change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
