Dandandan commented on code in PR #8552:
URL: https://github.com/apache/arrow-datafusion/pull/8552#discussion_r1430308163
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -327,12 +354,16 @@ pub fn create_hashes<'a>(
array => hash_dictionary(array, random_state, hashes_buffer,
rehash)?,
_ => unreachable!()
}
+ DataType::Struct(_) => {
+ let array = as_struct_array(array)?;
+ hash_struct_array(array, random_state, hashes_buffer)?;
Review Comment:
This should work?
```suggestion
create_hashes(array.columns(), random_state, hashes_buffer)?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
