jp0317 commented on code in PR #39153:
URL: https://github.com/apache/arrow/pull/39153#discussion_r1430772965
##########
cpp/src/parquet/column_reader.h:
##########
@@ -368,6 +368,16 @@ class PARQUET_EXPORT RecordReader {
virtual void DebugPrintState() = 0;
+ /// \brief Returns the dictionary owned by the current decoder. Throws an
+ /// exception if the current decoder is not for dictionary encoding. The
caller is
+ /// responsible for casting the returned pointer to proper type depending on
the
+ /// column's physical type. An example:
+ /// ByteArray* dict = reinterpret_cast<const
ByteArray*>(ReadDictionary(&len));
+ /// or:
+ /// float* dict = reinterpret_cast<const float*>(ReadDictionary(&len));
Review Comment:
done, thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
