my-vegetable-has-exploded commented on PR #5217:
URL: https://github.com/apache/arrow-rs/pull/5217#issuecomment-1862553213
> Can you please add tests for
>
> 1. `distinct` / `not_distinct`
>
> 2. A negative test that some operation like `lt` or `lt_eq` returns an
error (not a panic) for struct arrays?
>
> 3. A negative test that a struct array like `{a: int, b:int}` doesn't
return `true` when compared to a struct array with a prefix like `{a:int}
Sure.
> Correct, but the semantic of these kernels is any comparison against a
null results in null output for that position
I was wondering if it would be better to use ```Op::NotDistinct``` to check
each field? More precisely, we need to go through the process in
https://github.com/apache/arrow-rs/blob/9e060dc6c68e6aac30d0ae643d1d1854db44a378/arrow-ord/src/cmp.rs#L226-L284
after getting BooleanBuffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
