liukun4515 commented on code in PR #8580:
URL: https://github.com/apache/arrow-datafusion/pull/8580#discussion_r1432170963
##########
datafusion/core/tests/dataframe/dataframe_functions.rs:
##########
@@ -186,6 +187,25 @@ async fn test_fn_approx_percentile_cont() -> Result<()> {
assert_batches_eq!(expected, &batches);
+ // the arg2 parameter is a complex expr, but it can be evaluated to the
literal value
Review Comment:
yes, the rule of `simplfy_expression` can handle the alisa expr.
But the `cast(1 as float)` will be simplified.
I think this is the diff between the cast and alisa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
