viirya commented on code in PR #5226:
URL: https://github.com/apache/arrow-rs/pull/5226#discussion_r1432377995
##########
arrow-cast/src/cast.rs:
##########
@@ -160,11 +160,18 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
(Decimal128(_, _) | Decimal256(_, _), Utf8 | LargeUtf8) => true,
// Utf8 to decimal
(Utf8 | LargeUtf8, Decimal128(_, _) | Decimal256(_, _)) => true,
- (Struct(from_fields), Struct(to_fields)) => {
Review Comment:
I think it is better to fix the tab with space, otherwise the diff always
shows a wrong indent.
The comment is good to have to explain why nullability is ignored there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
