jorisvandenbossche commented on code in PR #39065:
URL: https://github.com/apache/arrow/pull/39065#discussion_r1432485419
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -897,16 +907,25 @@ Result<std::vector<compute::Expression>>
ParquetFileFragment::TestRowGroups(
ARROW_ASSIGN_OR_RAISE(auto match, ref.FindOneOrNone(*physical_schema_));
if (match.empty()) continue;
- if (statistics_expressions_complete_[match[0]]) continue;
- statistics_expressions_complete_[match[0]] = true;
+ const SchemaField* schema_field = &manifest_->schema_fields[match[0]];
Review Comment:
You mean including the for loop below, right?
I think a method on the SchemaManifest might be a logical place to have
this. It already has a `GetColumnField` to return a SchemaField based on a
single integer index. There could be a variant which accepts a FieldPath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
