felipecrv commented on code in PR #39298:
URL: https://github.com/apache/arrow/pull/39298#discussion_r1432755361
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -798,7 +864,7 @@ class AzureFileSystem::Impl {
std::unique_ptr<DataLake::DataLakeServiceClient> datalake_service_client_;
std::unique_ptr<Blobs::BlobServiceClient> blob_service_client_;
- internal::HierarchicalNamespaceDetector hns_detector_;
+ HNSSupport cached_hns_support_ = HNSSupport::kUnknown;
Review Comment:
I will consider extracting the memoized `HierarchicalNamespaceSupport()`
check to a separate class (added to my TODO list together with splitting the
`azurefs.cc` file), but I maintain that having an underlying function that
doesn't do any mutable state manipulation (just the request to the backend)
makes it easier to reason about the correctness and cost of the calls.
> AzureFileSystem would never be used in multiple threads. I think only
RandomAccessFile::ReadAt is used concurrently.
I meant `AzureFileSystem` itself would be using multiple threads to run the
operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
