avantgardnerio commented on code in PR #7942:
URL: https://github.com/apache/arrow-datafusion/pull/7942#discussion_r1432757547
##########
datafusion/expr/src/expr.rs:
##########
@@ -81,8 +81,10 @@ use std::sync::Arc;
/// assert_eq!(binary_expr.op, Operator::Eq);
/// }
/// ```
-#[derive(Clone, PartialEq, Eq, Hash, Debug)]
+#[derive(Clone, PartialEq, Eq, Hash, Debug, Default)]
pub enum Expr {
+ #[default]
Review Comment:
Clarification: is `nop` "no op(eration)"? If so, could we use the more
industry standard `Noop`? A quick google search seems to be evidence for it's
prevalence:
https://www.google.com/search?client=firefox-b-1-d&q=abbreviate+no+operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
