pitrou commented on code in PR #39323:
URL: https://github.com/apache/arrow/pull/39323#discussion_r1432871317
##########
cpp/src/arrow/filesystem/azurefs.h:
##########
@@ -21,6 +21,7 @@
#include <string>
#include <vector>
+#include "arrow/filesystem/azurefs_internal.h"
Review Comment:
Is this a mistake? We should not include an internal header in a public
header.
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -571,15 +581,14 @@ class ObjectInputFile final : public io::RandomAccessFile
{
std::shared_ptr<const KeyValueMetadata> metadata_;
};
-Status CreateEmptyBlockBlob(std::shared_ptr<Blobs::BlockBlobClient>
block_blob_client) {
+Status CreateEmptyBlockBlob(Blobs::BlockBlobClient& block_blob_client) {
Review Comment:
If not const, can we pass it as pointer?
```suggestion
Status CreateEmptyBlockBlob(Blobs::BlockBlobClient* block_blob_client) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
