comphead commented on PR #8550: URL: https://github.com/apache/arrow-datafusion/pull/8550#issuecomment-1864972096
> > lgtm thanks @alamb btw what do you think about adding a mandatory description on the test query and eventually output it? > > Thanks @comphead -- I am not quite sure what you mean > > Do you mean require a comment on each query that explains what is expected? It sounds reasonable to me, though if we aren't careful we'll end up with comments like `# ensure correct output` which probably don't add much value composing a correct description can be part of review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
