kou commented on code in PR #39316:
URL: https://github.com/apache/arrow/pull/39316#discussion_r1433283358
##########
python/CMakeLists.txt:
##########
@@ -391,6 +375,31 @@ install(TARGETS arrow_python
LIBRARY DESTINATION .
RUNTIME DESTINATION .)
+set(PYARROW_CPP_ENCRYPTION_SRCS
${PYARROW_CPP_SOURCE_DIR}/parquet_encryption.cc)
+if(NOT PYARROW_BUILD_PARQUET_ENCRYPTION)
+ message(STATUS "Parquet Encryption is NOT Enabled")
+else()
+ if(PARQUET_REQUIRE_ENCRYPTION)
+ if(ARROW_BUILD_SHARED)
+ set(PYARROW_CPP_ENCRYPTION_LINK_LIBS Parquet::parquet_shared)
+ else()
+ set(PYARROW_CPP_ENCRYPTION_LINK_LIBS Parquet::parquet_static)
+ endif()
Review Comment:
Can we reuse `PARQUET_LINK_LIBS` instead of definition this?
##########
python/CMakeLists.txt:
##########
@@ -814,6 +823,7 @@ endif()
if(PYARROW_BUILD_PARQUET)
target_link_libraries(_parquet PRIVATE ${PARQUET_LINK_LIBS})
if(PYARROW_BUILD_PARQUET_ENCRYPTION)
- target_link_libraries(_parquet_encryption PRIVATE ${PARQUET_LINK_LIBS})
+ target_link_libraries(_parquet_encryption PRIVATE ${PARQUET_LINK_LIBS}
+
arrow_python_parquet_encryption)
Review Comment:
Can we remove `${PARQUET_LINK_LIBS}` here because
`arrow_python_parquet_encryption` already depends on `${PARQUET_LINK_LIBS}`?
```suggestion
target_link_libraries(_parquet_encryption PRIVATE
arrow_python_parquet_encryption)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
